On 1/18/06, Ted Husted <[EMAIL PROTECTED]> wrote: > > On 1/18/06, Laurie Harper <[EMAIL PROTECTED]> wrote: > > If the goal is to be able to run a tool to get checkstyle 'conformance' > > wouldn't it be better to tailer checkstyle to a tool anyone could grab, > > rather than tailoring it to what IDEA can do? Don't get me wrong, I love > > IDEA and I'd be quite happy to be able to use it for this, but not > > everyone has IDEA... > > > > +1 in principle, though. > > Jetbrains has donated licenses for the use of any and all ASF > committers, so anyone with write privilges can indeed grab IDEA and > use it to reformat the code on demand. Moreover, the reformatter is > very clever and doesn't "touch" files that do not need reformatting. > Any one can bring the codebase up to date in a matter of seconds > (literally) and commit back on the files that needed style fixes. The > important thing would be to continue to follow the longstanding rule > to separate style-change commnits from code-change commits. > > As I understand, WebWork 2.2 is styled using the factory-default IDEA > settings. If we want that codebase to pass CheckStyle in the future, > eventually, we will need to conform one or the other. > > But, yes, I'm thinking that it might be less work to conform > CheckStyle to IDEA than the other way around. The goal should be to > ensure that a uniform coding style is consistently applied.
We've used Checkstyle for our coding guidelines ever since I can remember. I'm personally not in favour of changing the coding guidelines just to fit IDEA. Maybe we _can_ all download IDEA, but that doesn't mean that we all _want_ to install another IDE just for the sake of coding guidelines. I'd be much more inclined to add the Maven Jalopy plugin to an optional goal. Then nobody has to install anything (manually). We know you love your choice of tools, Ted, and you love promoting them, but that doesn't mean we all share your love for the same tools. ;-) -- Martin Cooper -Ted. > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > >
