mistercrunch commented on a change in pull request #4760: URL shortner for
dashboards
URL:
https://github.com/apache/incubator-superset/pull/4760#discussion_r180230983
##########
File path: superset/assets/javascripts/components/URLShortLinkButton.jsx
##########
@@ -1,13 +1,14 @@
import React from 'react';
import PropTypes from 'prop-types';
import { Popover, OverlayTrigger } from 'react-bootstrap';
-import CopyToClipboard from './../../components/CopyToClipboard';
-import { getShortUrl } from '../../../utils/common';
-import { getExploreLongUrl } from '../exploreUtils';
-import { t } from '../../locales';
+import CopyToClipboard from './CopyToClipboard';
+import { getShortUrl } from '../../utils/common';
+import { t } from '../locales';
const propTypes = {
- latestQueryFormData: PropTypes.object.isRequired,
+ url: PropTypes.string,
+ emailSubject: PropTypes.string,
Review comment:
Now that `emailSubject` and `emailContent` are the props, we should pass
them good values where the components are used. Also always is `.isRequired` OR
set `defaultProps`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
