mistercrunch commented on a change in pull request #4760: URL shortner for 
dashboards
URL: 
https://github.com/apache/incubator-superset/pull/4760#discussion_r179325574
 
 

 ##########
 File path: superset/assets/javascripts/dashboard/components/Dashboard.jsx
 ##########
 @@ -153,6 +157,27 @@ class Dashboard extends React.PureComponent {
     return this.props.filters[sliceId];
   }
 
+  addHistory({ isReplace = false, title }) {
+    const payload = { ...this.props.dashboard.metadata };
+    const longUrl = getDashboardLongUrl(this.props.dashboard);
+    if (isReplace) {
+      history.replaceState(
+        payload,
+        title,
+        longUrl);
+    } else {
+      history.pushState(
 
 Review comment:
   nit: this would fit on a single line

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to