williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180881331
########## File path: superset/assets/javascripts/dashboard/reducers/dashboard.js ########## @@ -0,0 +1,123 @@ +import d3 from 'd3'; Review comment: we should not import all of d3 for this utility function! please remove it. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services