williaster commented on a change in pull request #4839: Dashboard builder:
fixed 1st round comments
URL:
https://github.com/apache/incubator-superset/pull/4839#discussion_r182589180
##########
File path: superset/assets/javascripts/dashboard/reducers/dashboard.js
##########
@@ -0,0 +1,115 @@
+import { merge as mergeArray } from 'd3';
+
+import * as actions from '../actions/dashboard';
Review comment:
I would import all of these individually. also, should this file (similar to
actions) be called `dashboardState`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
