williaster commented on a change in pull request #4839: Dashboard builder:
fixed 1st round comments
URL:
https://github.com/apache/incubator-superset/pull/4839#discussion_r182594505
##########
File path: superset/assets/stylesheets/dashboard.less
##########
@@ -0,0 +1,260 @@
+@import "./less/cosmo/variables.less";
+
+.dashboard a i {
+ cursor: pointer;
+}
+.dashboard i.drag {
+ cursor: move !important;
+}
+.dashboard .slice-grid .preview-holder {
+ z-index: 1;
+ position: absolute;
+ background-color: #AAA;
+ border-color: #AAA;
+ opacity: 0.3;
+}
+.dashboard .widget {
+ position: absolute;
+ top: 16px;
+ left: 16px;
+ box-shadow: none;
+ background-color: transparent;
+ overflow: visible;
+}
+.dashboard .chart-header {
+ .dropdown.btn-group {
+ position: absolute;
+ top: 0;
+ right: 0;
+ }
+
+ .dropdown-menu.dropdown-menu-right {
+ right: 7px;
+ top: -3px
+ }
+}
+
+.slice-header-controls-trigger {
+ border: 0;
+ padding: 0 0 0 20px;
+ background: none;
+ outline: none;
+ box-shadow: none;
+ color: #263238;
+
+ &.is-cached {
+ color: red;
+ }
+
+ &:hover, &:focus {
+ background: none;
+ cursor: pointer;
+ }
+
+ .controls-container.dropdown-menu {
+ top: 0;
+ left: unset;
+ right: 10px;
+
+ &.is-open {
+ display: block;
+ }
+
+ & li {
+ white-space: nowrap;
+ }
+ }
+}
+.slice-grid .slice_container {
+ background-color: #fff;
+}
+
+.dashboard .slice-grid .dragging,
+.dashboard .slice-grid .resizing {
+ opacity: 0.5;
+}
+.dashboard img.loading {
+ width: 20px;
+ margin: 5px;
+ position: absolute;
+}
+
+.dashboard .slice_title {
+ text-align: center;
+ font-weight: bold;
+ font-size: 14px;
+ padding: 5px;
+}
+.dashboard div.slice_content {
+ width: 100%;
+ height: 100%;
+}
+
+.modal img.loading {
+ width: 50px;
+ margin: 0;
+ position: relative;
+}
+
+.react-bs-container-body {
+ max-height: 400px;
+ overflow-y: auto;
+}
+
+.hidden, #pageDropDown {
+ display: none;
+}
+
+.slice-cell {
+ box-shadow: 0px 0px 20px 5px rgba(0,0,0,0);
+ transition: box-shadow 1s ease-in;
+
+ .dropdown,
+ .dropdown-menu {
+ .fa {
+ font-size: 14px;
+ }
+ }
+}
+
+.slice-cell-highlight {
+ box-shadow: 0px 0px 20px 5px rgba(0,0,0,0.2);
+ height: 100%;
+}
+
+.slice-cell .editable-title input[type="button"] {
+ font-weight: bold;
+}
+
+.chart-container {
+ box-sizing: border-box;
+}
+
+.chart-header .header {
+ font-size: 16px;
+ margin: 0 -10px;
+}
+.ace_gutter {
+ z-index: 0;
+}
+.ace_content {
+ z-index: 0;
+}
+.ace_scrollbar {
+ z-index: 0;
+}
+.slice_container .alert {
+ margin: 10px;
+}
+
+i.danger {
+ color: red;
+}
+
+i.warning {
+ color: orange;
+}
+
+.dashboard-builder-sidepane {
+ .trigger {
+ height: 25px;
+ width: 25px;
+ color: #879399;
+ position: relative;
+
+ &.close {
+ top: 3px;
+ }
+
+ &.open {
+ position: absolute;
+ right: 14px;
+ }
+ }
+}
+
+.component-layer {
+ .new-component.static {
+ cursor: pointer;
Review comment:
if it's static should the pointer be `initial`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
