williaster commented on a change in pull request #4839: Dashboard builder:
fixed 1st round comments
URL:
https://github.com/apache/incubator-superset/pull/4839#discussion_r182589479
##########
File path: superset/assets/javascripts/dashboard/reducers/initState.js
##########
@@ -0,0 +1,106 @@
+import { chart } from '../../chart/chartReducer';
+import { initSliceEntities } from './sliceEntities';
+import { getParam } from '../../modules/utils';
+import { applyDefaultFormData } from '../../explore/stores/store';
+import { getColorFromScheme } from '../../modules/colors';
+import layoutConverter from '../util/dashboardLayoutConverter';
+
+export default function(bootstrapData) {
Review comment:
I think you'll get some .eslint errors for this soon, but debugging is
easier if you name your functions
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
