williaster commented on a change in pull request #4839: Dashboard builder:
fixed 1st round comments
URL:
https://github.com/apache/incubator-superset/pull/4839#discussion_r182589335
##########
File path: superset/assets/javascripts/dashboard/reducers/index.js
##########
@@ -0,0 +1,29 @@
+import { combineReducers } from 'redux';
+import shortid from 'shortid';
+
+import charts from '../../chart/chartReducer';
+import dashboardState from './dashboard';
+import datasources from './datasources';
+import sliceEntities from './sliceEntities';
+import dashboardLayout from '../v2/reducers/index';
Review comment:
should you update the `/v2/reducers/index` file to be called
`dashboardLayout`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
