ilgrosso commented on a change in pull request #301:
URL: https://github.com/apache/syncope/pull/301#discussion_r777323796
##########
File path: .github/workflows/codeql-analysis.yml
##########
@@ -18,7 +18,7 @@ name: "CodeQL"
on:
push:
- branches: [master,2_1_X]
+ branches: [master,2_1_X,pr-*]
Review comment:
I don't understand such changes to GH workflow: has anything changed
lately? Otherwise, such changes are not required to let the workflows run on
PRs.
##########
File path: fit/wa-reference/src/main/resources/log4j2.xml
##########
@@ -63,7 +63,11 @@ under the License.
<appender-ref ref="main"/>
</asyncLogger>
- <asyncLogger name="org.apache.cxf" additivity="false" level="ERROR">
+ <asyncLogger name="org.apache.cxf" additivity="false" level="DEBUG">
+ <appender-ref ref="main"/>
+ </asyncLogger>
+
+ <asyncLogger name="org.springframework.security" additivity="false"
level="DEBUG">
Review comment:
Please revert, as this file is taken by archetype as reference for new
projects.
##########
File path:
core/starter/src/main/java/org/apache/syncope/core/starter/SyncopeCoreApplication.java
##########
@@ -105,4 +221,31 @@ public SyncopeCoreStart keymasterStart(final DomainHolder
domainHolder) {
public KeymasterStop keymasterStop() {
return new KeymasterStop(NetworkService.Type.CORE);
}
+
Review comment:
Is introducing these two new interfaces / default implementations the
only way to go?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
