ilgrosso commented on a change in pull request #301:
URL: https://github.com/apache/syncope/pull/301#discussion_r777347946
##########
File path:
core/starter/src/main/java/org/apache/syncope/core/starter/SyncopeCoreApplication.java
##########
@@ -105,4 +221,31 @@ public SyncopeCoreStart keymasterStart(final DomainHolder
domainHolder) {
public KeymasterStop keymasterStop() {
return new KeymasterStop(NetworkService.Type.CORE);
}
+
Review comment:
I understand the problem now: I'd say then we need to handle this whole
item apart for next PR (keeping the current changes in this PR, anyway) - we're
talking here about "residual" beans, as several ones were converted into the
interface + default impl approach in the recent past.
I'd say that such new interfaces / default impls should be treated properly
in separate files, too, rather than being embedded in Application /
Configuration classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
