mmoayyed commented on a change in pull request #301:
URL: https://github.com/apache/syncope/pull/301#discussion_r777330507



##########
File path: 
core/starter/src/main/java/org/apache/syncope/core/starter/SyncopeCoreApplication.java
##########
@@ -105,4 +221,31 @@ public SyncopeCoreStart keymasterStart(final DomainHolder 
domainHolder) {
     public KeymasterStop keymasterStop() {
         return new KeymasterStop(NetworkService.Type.CORE);
     }
+

Review comment:
       For example,
   
   ```
       @ConditionalOnMissingBean
       @Bean
       public AuthDataAccessor authDataAccessor() {}
   ```
   
   Will create a CGLib proxy; since the class is a concrete type and there is 
no interface to use for the proxy object. The general approach is to turn 
`AuthDataAccessor` into an interface, with a default implementation class, or 
something to that effect.
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to