mmoayyed commented on a change in pull request #301:
URL: https://github.com/apache/syncope/pull/301#discussion_r777330062
##########
File path:
core/starter/src/main/java/org/apache/syncope/core/starter/SyncopeCoreApplication.java
##########
@@ -105,4 +221,31 @@ public SyncopeCoreStart keymasterStart(final DomainHolder
domainHolder) {
public KeymasterStop keymasterStop() {
return new KeymasterStop(NetworkService.Type.CORE);
}
+
Review comment:
Yes, and this approach should be applied to all other bean
implementations that do not conform or implement an interface. Specially for
event-listeners in the absence of proxies. The `SyncopeCoreInfoContributor`
does some very strange things today and is combined to also react to a listener
and collect data; This violates many other principals , but I did not change
the way it works; mainly the event listener config is moved out of the
contributor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
