corepointer commented on a change in pull request #1101:
URL: https://github.com/apache/systemds/pull/1101#discussion_r523475424
##########
File path: src/main/cpp/libmatrixmult.h
##########
@@ -17,48 +17,19 @@
* under the License.
*/
-#ifndef _libmatrixmult_h
-#define _libmatrixmult_h
+#ifndef LIBMATRIXMULT_H
+#define LIBMATRIXMULT_H
Review comment:
Depending on your conventions - yes. I was/is a convention for most
people I've worked with. I must have adopted it at some point.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
