corepointer commented on a change in pull request #1101:
URL: https://github.com/apache/systemds/pull/1101#discussion_r523476513
##########
File path: src/main/cpp/systemds.h
##########
@@ -29,65 +29,65 @@ extern "C" {
/*
* Class: org_apache_sysds_utils_NativeHelper
* Method: dmmdd
- * Signature: ([D[D[DIIII)Z
+ * Signature: ([D[D[DIIII)I
Review comment:
That is machine generated stuff by javah. I couldn't resist to update
the signature after changing the function's parameters even though it says
specifically to not edit this file. So yes, I admit that I did not bother to
run through javah again for the changes I made 😊
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
