corepointer commented on a change in pull request #1101:
URL: https://github.com/apache/systemds/pull/1101#discussion_r523476161
##########
File path: src/main/cpp/systemds.cpp
##########
@@ -215,14 +203,14 @@ JNIEXPORT jint JNICALL
Java_org_apache_sysds_utils_NativeHelper_sconv2dBiasAddDe
if(inputPtr == NULL || biasPtr == NULL || filterPtr == NULL || retPtr ==
NULL)
return (jint) -1;
- int nnz = sconv2dBiasAddDense(inputPtr, biasPtr, filterPtr, retPtr,
- (int) N, (int) C, (int) H, (int) W, (int) K, (int) R, (int) S,
- (int) stride_h, (int) stride_w, (int) pad_h, (int) pad_w, (int) P, (int)
Q, true, (int) numThreads);
-
- return (jint) nnz;
+ size_t nnz = sconv2dBiasAddDense(inputPtr, biasPtr, filterPtr, retPtr, (int)
N, (int) C, (int) H, (int) W, (int) K,
+ (int) R,
(int) S, (int) stride_h, (int) stride_w, (int) pad_h, (int) pad_w, (int) P,
+ (int) Q,
true, (int) numThreads);
+
+ return static_cast<jlong>(nnz);
}
-JNIEXPORT jint JNICALL
Java_org_apache_sysds_utils_NativeHelper_conv2dBackwardDataDense(
+JNIEXPORT jlong JNICALL
Java_org_apache_sysds_utils_NativeHelper_conv2dBackwardDataDense(
JNIEnv* env, jclass, jdoubleArray filter, jdoubleArray dout,
jdoubleArray ret, jint N, jint C, jint H, jint W, jint K, jint R, jint S,
jint stride_h, jint stride_w, jint pad_h, jint pad_w, jint P, jint Q, jint
numThreads) {
Review comment:
As noted in the commit message: cleanup is WIP. I believe I gave it a
two tab line continuation indent now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
