corepointer commented on a change in pull request #1101:
URL: https://github.com/apache/systemds/pull/1101#discussion_r523476098
##########
File path: src/main/cpp/systemds.cpp
##########
@@ -192,18 +180,18 @@ JNIEXPORT jint JNICALL
Java_org_apache_sysds_utils_NativeHelper_dconv2dBiasAddDe
if(inputPtr == NULL || biasPtr == NULL || filterPtr == NULL || retPtr ==
NULL)
return (jint) -1;
- int nnz = dconv2dBiasAddDense(inputPtr, biasPtr, filterPtr, retPtr,
- (int) N, (int) C, (int) H, (int) W, (int) K, (int) R, (int) S,
- (int) stride_h, (int) stride_w, (int) pad_h, (int) pad_w, (int) P, (int)
Q, true, (int) numThreads);
+ size_t nnz = dconv2dBiasAddDense(inputPtr, biasPtr, filterPtr, retPtr, (int)
N, (int) C, (int) H, (int) W, (int) K,
+ (int) R,
(int) S, (int) stride_h, (int) stride_w, (int) pad_h, (int) pad_w, (int) P,
+ (int) Q,
true, (int) numThreads);
Review comment:
Mental note: make a clang-tidy config to aid proper formatting. A
plethora of editors and IDEs are in use (Visual Studio, Eclipse, IntelliJ,
CLion, QT Creator, Kate, Vim, Gedit, Notepad++ all had a go at these files 😨 )
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
