Baunsgaard commented on a change in pull request #1199:
URL: https://github.com/apache/systemds/pull/1199#discussion_r603899299
##########
File path: src/main/java/org/apache/sysds/hops/BinaryOp.java
##########
@@ -496,7 +498,7 @@ else if (mbin == MMBinaryMethod.MR_BINARY_M) {
setOutputDimensions(binary);
setLineNumbers(binary);
setLops(binary);
- }
+ } else throw new HopsException("Lop construction not
implemented for ExecType " + et);
Review comment:
in this pr you do it two different ways, i liked the first better with
newline and brackets. I personally would prefer if there was a newline for the
throw, if you want to include brackets or not is up to you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
