sebwrede commented on a change in pull request #1199:
URL: https://github.com/apache/systemds/pull/1199#discussion_r603900326



##########
File path: src/main/java/org/apache/sysds/hops/ReorgOp.java
##########
@@ -76,6 +77,8 @@ public ReorgOp(String l, DataType dt, ValueType vt, ReOrgOp 
o, ArrayList<Hop> in
                        getInput().add(i, in);
                        in.getParent().add(this);
                }
+
+               updateETFed();

Review comment:
       It is important to have both. In the first one, the execution type and 
fedoutput will be set during the construction of the Hops (in the order input 
to output). In the second call in "optFindExecType", it will set the exectype 
so that a once federated execution is not converted to a CP. This will happen 
in the order output to input (plus additional calls in certain cases).  




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to