sebwrede commented on a change in pull request #1199:
URL: https://github.com/apache/systemds/pull/1199#discussion_r603923892
##########
File path: src/main/java/org/apache/sysds/hops/BinaryOp.java
##########
@@ -496,7 +498,7 @@ else if (mbin == MMBinaryMethod.MR_BINARY_M) {
setOutputDimensions(binary);
setLineNumbers(binary);
setLops(binary);
- }
+ } else throw new HopsException("Lop construction not
implemented for ExecType " + et);
Review comment:
I have now changed the other throw so that it is also on the same line.
I generally think that it is acceptable to have both, since it makes more
sense in some cases to have it on a single line. It depends on the context. If,
for instance, the other if-else parts are without brackets then it makes more
sense to have the throw on a single line without brackets as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
