sebwrede commented on a change in pull request #1199:
URL: https://github.com/apache/systemds/pull/1199#discussion_r603903661
##########
File path:
src/main/java/org/apache/sysds/runtime/instructions/fed/BinaryFEDInstruction.java
##########
@@ -42,11 +47,12 @@ public static BinaryFEDInstruction parseInstruction(String
str) {
}
String[] parts =
InstructionUtils.getInstructionPartsWithValueType(str);
- InstructionUtils.checkNumFields(parts, 3, 4);
+ InstructionUtils.checkNumFields(parts, 3, 4, 5);
String opcode = parts[0];
CPOperand in1 = new CPOperand(parts[1]);
CPOperand in2 = new CPOperand(parts[2]);
CPOperand out = new CPOperand(parts[3]);
+ boolean federatedOutput = parts.length > 5 &&
Boolean.parseBoolean(parts[5]);
Review comment:
Number 4 is the number of threads. I assume that this has been included,
otherwise we cannot parse a federated output. I try to only write federated
output in the cases where it is true, but I leave room for also writing false
to the instruction string. This is the reason why I check if it has been
included and parse it if it has been included.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
