Hi Sagar, I have reviewed the PR. Please look and fix all of these that i have mentioned.
Thanks On Jun 2, 2016 11:23 AM, "Rajan Maurya" <[email protected]> wrote: > Hi Sagar, > > Its looks good. I will review it today and update you if there is any > need to change. > > Implement rest of Announcement Details part > > Good :) > > > On Thu, Jun 2, 2016 at 10:58 AM, Sagar <[email protected]> wrote: > >> Hi All, >> My semester end exam gone well and I am starting my internship on this >> project as we talk earlier, Now I started working on Taverna Mobile >> Application. >> >> I go through Rajan Maurya's GsoC proposal and found he researched well and >> I am following it as accordingly. >> >> I have sent a pull request (PR no #14 >> <https://github.com/apache/incubator-taverna-mobile/pull/14>) and I have >> added some libraries and start working on Announcements features. >> >> - Added MVP architecture basic >> - Setup Retrofit >> - Setup Simple xml parser >> - Setup Rx-JAVA and Rx-Android >> - Setup ButterKnife >> - Design Announcement layout >> - Working ListView to show all Announcements >> - [WIP] Detail of clicked Announcement >> >> I am currently working on it. >> >> Rajan Maurya, Please reviews the #PR >> <https://github.com/apache/incubator-taverna-mobile/pull/14> till now >> and >> suggests me something if there is something needed to change . >> >> If anyone else wants to work on it or review my work, it'd be great. >> >> -- >> >> *With warm regards * >> *Sincerely yours* >> Sagar >> >> >> *Student ,(6th Semester )B.Tech IT and mathematical innovation* >> *Cluster Innovation Centre* >> *University of Delhi * >> > > > > -- > *Thanks* > *Namaste* > > Rajan Maurya > Contact Number : +91 8010665248 > Github : https://github.com/therajanmaurya > College : Cluster Innovation Centre, University of Delhi > Student : B.Tech. (Information Technology & Mathematical Innovations) > >
