Hi,
Thanks, Rajan Maurya to help in person. I have implemented the code analysis and all Travis build are passing. Here is my PR <https://github.com/apache/incubator-taverna-mobile/pull/15> Please look. Rajan, please review my code. Thanks. On Fri, Jun 10, 2016 at 8:13 PM, Rajan Maurya <[email protected]> wrote: > Hi stain, > > Please merge the Travis CI PR . > > If we don't have problem to use Travis in place Jenkins. > > Or you can enable Jenkins. > > It will very helpful for me review the Sagar next PR Code Analysis Tools > Implementation with Travis or Jenkins. > On 8 Jun 2016 6:02 p.m., "Sagar" <[email protected]> wrote: > > > Hi Stain, > > > > I have added ASF file header in all newly added file .Please check and > > merge it so that I work on next feature because this is the base of my > next > > PRs. > > > > Thanks > > > > On Mon, Jun 6, 2016 at 9:24 PM, Rajan Maurya <[email protected]> > > wrote: > > > > > Actually, the good way to manage and list the dependencies is : > > > > > > > > > > > > https://github.com/therajanmaurya/android-client/blob/MVP-Phase-1/mifosng-android/build.gradle > > > and > > > > > > > > > https://github.com/therajanmaurya/android-client/blob/MVP-Phase-1/build.gradle > > > > > > But I think, It has to be in separate #PR. So, Sagar will open his next > > PR > > > of managing the build.gradle. > > > > > > And About the licenses of the dependencies, we don't need to mention > here > > > we will add all dependencies licenses in Application (All Libraries > used > > > license). > > > As a Feature. > > > > > > Thanks > > > > > > > > > On Monday, June 6, 2016, Stian Soiland-Reyes <[email protected]> wrote: > > > > > > > On 5 June 2016 at 22:03, Sagar <[email protected]> wrote: > > > > > Hi Rajan, > > > > > > > > > > I have fixed all your input. Please review it again and suggests > me > > > > > something if there is something needed to change . > > > > > > > > > > If anyone else wants to work on it or review my work, it'd be > great. > > > > > > > > Thanks both! I've commented on the pull request that we just need > some > > > > ASF headers on the new files, so we know they are licensed correctly. > > > > > > > > > > > > > > > > > > https://github.com/apache/incubator-taverna-mobile/pull/14#issuecomment-223956980 > > > > > > > > (Note the license headers are not quite consistent in the rest of > > > > Taverna Mobile, see also > > > > https://issues.apache.org/jira/browse/TAVERNA-976 ) > > > > > > > > > > > > I checked the licenses of the new dependencies manually - they are > all > > > > ASF 2.0 and so compabible. But do you know if there is a good Gradle > > > > way to list all dependencies (including transitives) and their > > > > licenses? > > > > > > > > > > > > > > > > > > https://github.com/sagar15795/incubator-taverna-mobile/blob/Announcement/app/build.gradle#L31 > > > > > > > > -- > > > > Stian Soiland-Reyes > > > > Apache Taverna (incubating), Apache Commons > > > > http://orcid.org/0000-0001-9842-9718 > > > > > > > > > > > > > -- > > > *Thanks* > > > *Namaste* > > > > > > Rajan Maurya > > > Contact Number : +91 8010665248 > > > Github : https://github.com/therajanmaurya > > > College : Cluster Innovation Centre, University of Delhi > > > Student : B.Tech. (Information Technology & Mathematical Innovations) > > > > > > > > > > > -- > > > > *With warm regards * > > *Sincerely yours* > > Sagar > > > > > > *Student ,(6th Semester )B.Tech IT and mathematical innovation* > > *Cluster Innovation Centre* > > *University of Delhi * > > > -- *With warm regards * *Sincerely yours* Sagar *Student ,(6th Semester )B.Tech IT and mathematical innovation* *Cluster Innovation Centre* *University of Delhi *
