[
https://issues.apache.org/jira/browse/THRIFT-1353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13112799#comment-13112799
]
Roger Meier commented on THRIFT-1353:
-------------------------------------
Hi Hans!
Thanks for bringing new ideas and bugfixes to Thrift Node.js implementation!
Could you please create a patch and grant License to ASF?
see: http://wiki.apache.org/thrift/HowToContribute
Another important topic are Unit Tests, see my comments on THRIFT-1261
do you have some?
I'm looking forward to commit patches for Node.js!
Thanks
roger
> Switch to performance branch, get rid of BinaryParser
> -----------------------------------------------------
>
> Key: THRIFT-1353
> URL: https://issues.apache.org/jira/browse/THRIFT-1353
> Project: Thrift
> Issue Type: Improvement
> Components: Node.js - Library
> Affects Versions: 0.7
> Reporter: Hans Duedal
> Labels: node, nodejs
> Fix For: 0.8
>
>
> I vote that the thrift library switches to the performance branch at
> https://github.com/wadey/node-thrift/tree/performance
> I much prefer using the node.js buffers over the BinaryParser class, the
> performance branch seems focused on this very issue. Also it includes the
> excellent int64 implementation from broofa. What's not to like?
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
