[
https://issues.apache.org/jira/browse/THRIFT-1353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13121349#comment-13121349
]
Wade Simmons commented on THRIFT-1353:
--------------------------------------
I merged node-thrift 0.7.0 with my performance branch, and plan to submit to
Thrift for 0.8.0. Can I get a few people to test this?
* `thrift-dev` on npm
* https://github.com/wadey/node-thrift/tree/performance
You will need this compiler patch:
https://issues.apache.org/jira/browse/THRIFT-1351
Two non-backwords compatible changes:
* "binary" fields will be returned as Buffers instead of Strings
* "int64" fields will be returned as http://github.com/broofa/node-int64 objects
> Switch to performance branch, get rid of BinaryParser
> -----------------------------------------------------
>
> Key: THRIFT-1353
> URL: https://issues.apache.org/jira/browse/THRIFT-1353
> Project: Thrift
> Issue Type: Improvement
> Components: Node.js - Library
> Affects Versions: 0.7
> Reporter: Hans Duedal
> Labels: node, nodejs
> Fix For: 0.8
>
>
> I vote that the thrift library switches to the performance branch at
> https://github.com/wadey/node-thrift/tree/performance
> I much prefer using the node.js buffers over the BinaryParser class, the
> performance branch seems focused on this very issue. Also it includes the
> excellent int64 implementation from broofa. What's not to like?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
