[
https://issues.apache.org/jira/browse/THRIFT-2926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14272011#comment-14272011
]
ASF GitHub Bot commented on THRIFT-2926:
----------------------------------------
GitHub user radekg reopened a pull request:
https://github.com/apache/thrift/pull/345
THRIFT-2926: JS: Binary protocol with unit tests.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/radekg/thrift js-binary-protocol
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/345.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #345
----
commit e79c300f09eb781bee5a2cc402bea0eb370ca2a4
Author: radekg <[email protected]>
Date: 2015-01-02T16:12:45Z
JS: Binary protocol with unit tests.
commit e74c0d7c40fe3de9312ee571990fcbac8fa28249
Author: radekg <[email protected]>
Date: 2015-01-05T19:28:23Z
Integrated TBinaryProtocol into grunt tests to present the PhantonJS issue.
----
> JavaScript: binary protocol implementation
> ------------------------------------------
>
> Key: THRIFT-2926
> URL: https://issues.apache.org/jira/browse/THRIFT-2926
> Project: Thrift
> Issue Type: Sub-task
> Components: JavaScript - Library
> Affects Versions: 0.9.2
> Reporter: Radoslaw Gruchalski
> Assignee: Randy Abernethy
> Labels: features, javascript
>
> I have implemented BinaryProtocol for the JS library. Implementation provided
> with unit tests. Looking for feedback.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
