[
https://issues.apache.org/jira/browse/THRIFT-2926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14299858#comment-14299858
]
Randy Abernethy commented on THRIFT-2926:
-----------------------------------------
Hey Guys,
Where are we with this patch? I just tried to commit but the
qunit:ThriftBinaryProtocol test still fails. I cleaned up the white space and
did a subst to change the proto from BinaryProtocol to TBinaryProtocol.
Also tried the UTF-8 exports Roger mentions.
[~radekg] if you can mod the phantom tests to leave out the strings so that
they pass and leave the full tests for manual browser use we can get this
committed.
Best,
Randy
> JavaScript: binary protocol implementation
> ------------------------------------------
>
> Key: THRIFT-2926
> URL: https://issues.apache.org/jira/browse/THRIFT-2926
> Project: Thrift
> Issue Type: Sub-task
> Components: JavaScript - Library
> Affects Versions: 0.9.2
> Reporter: Radoslaw Gruchalski
> Assignee: Randy Abernethy
> Labels: features, javascript
>
> I have implemented BinaryProtocol for the JS library. Implementation provided
> with unit tests. Looking for feedback.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)