[
https://issues.apache.org/jira/browse/THRIFT-2926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14272894#comment-14272894
]
ASF GitHub Bot commented on THRIFT-2926:
----------------------------------------
Github user bufferoverflow commented on the pull request:
https://github.com/apache/thrift/pull/345#issuecomment-69494103
Thanks @radekg for this udate.
any idea about the jslint issues?
cd lib/js/test
make check
lib/js/test/build.xml:216: JSLint: 39 errors in 1 file
They might be related to the unit test issues:
```
cd lib/js/test
ant unittest
...
unittest:
[echo] Running Unit Tests with headless browser!
[exec] Xlib: extension "RANDR" missing on display ":99".
[java] Timeout: killed the sub-process
[java] Java Result: -1
[exec] 'waitFor()' finished in 403ms.
[exec] Tests completed in 267 milliseconds.
[exec] 4 assertions of 41 passed, 37 failed.
```
You can also remove ThriftTest.thrift file from this commit it is a
duplication.
> JavaScript: binary protocol implementation
> ------------------------------------------
>
> Key: THRIFT-2926
> URL: https://issues.apache.org/jira/browse/THRIFT-2926
> Project: Thrift
> Issue Type: Sub-task
> Components: JavaScript - Library
> Affects Versions: 0.9.2
> Reporter: Radoslaw Gruchalski
> Assignee: Randy Abernethy
> Labels: features, javascript
>
> I have implemented BinaryProtocol for the JS library. Implementation provided
> with unit tests. Looking for feedback.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
