[
https://issues.apache.org/jira/browse/THRIFT-2926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14300050#comment-14300050
]
Andrew de Andrade commented on THRIFT-2926:
-------------------------------------------
FWIW, this looks to only apply to the js implementation in lib/js. My intent is
to get the nodejs code all working in the browser via browserify. I've already
been able to implement this and test successfully (in this proof of concept
commit**) in phantomjs. The only tests I cannot successfully run in phantomjs
are the websockets tests because phantomjs 1.x.x doesn't implement the correct
websocket specifications, but phantomjs 2 does and should be released shortly.
The XHR proof of concept works flawlessly in phantomjs (I am using run-browser
https://github.com/ForbesLindesay/run-browser ).
If we get all the nodejs code working well in the browser, it's entirely
possible that we could completely deprecate the implementation in lib/js unless
someone has a strong reason to maintain that implementation. It's trivial to
take the nodejs browser capable implementation and package it up so it produces
a standalone file that exposes thrift as a global on the window object if that
is something people want.
**
https://github.com/uber/thrift/commit/9ca44b40504cc8d45d0c1e47709128e474d991df
(don't worry I'll break it up into smaller commits before submitting patches))
> JavaScript: binary protocol implementation
> ------------------------------------------
>
> Key: THRIFT-2926
> URL: https://issues.apache.org/jira/browse/THRIFT-2926
> Project: Thrift
> Issue Type: Sub-task
> Components: JavaScript - Library
> Affects Versions: 0.9.2
> Reporter: Radoslaw Gruchalski
> Assignee: Randy Abernethy
> Labels: features, javascript
>
> I have implemented BinaryProtocol for the JS library. Implementation provided
> with unit tests. Looking for feedback.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
