[
https://issues.apache.org/jira/browse/TIKA-2400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16173452#comment-16173452
]
ASF GitHub Bot commented on TIKA-2400:
--------------------------------------
ThejanW commented on a change in pull request #208: Fix for TIKA-2400
Standardizing current Object Recognition REST parsers
URL: https://github.com/apache/tika/pull/208#discussion_r140022863
##########
File path:
tika-parsers/src/main/java/org/apache/tika/parser/recognition/ObjectRecognitionParser.java
##########
@@ -83,12 +83,6 @@ public int compare(RecognisedObject o1, RecognisedObject
o2) {
}
};
- @Field
- private double minConfidence = 0.05;
Review comment:
Hey! good catch..it's not easy maintaining comments like
these(https://github.com/ThejanW/tika/blob/92c65e0a43e7f09a0566bec34f352314dffe5def/tika-parsers/src/main/java/org/apache/tika/parser/recognition/ObjectRecognitionParser.java#L49-L70)
A future developers will also miss these. Will update them asap :+1:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Standardizing current Object Recognition REST parsers
> -----------------------------------------------------
>
> Key: TIKA-2400
> URL: https://issues.apache.org/jira/browse/TIKA-2400
> Project: Tika
> Issue Type: Sub-task
> Components: parser
> Reporter: Thejan Wijesinghe
> Priority: Minor
> Fix For: 1.17
>
>
> # This involves adding apiBaseUris and refactoring current Object Recognition
> REST parsers,
> # Refactoring dockerfiles related to those parsers.
> # Moving the logic related to checking minimum confidence into servers
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
