[
https://issues.apache.org/jira/browse/TIKA-2400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16175914#comment-16175914
]
ASF GitHub Bot commented on TIKA-2400:
--------------------------------------
smadha commented on a change in pull request #208: Fix for TIKA-2400
Standardizing current Object Recognition REST parsers
URL: https://github.com/apache/tika/pull/208#discussion_r140411633
##########
File path:
tika-parsers/src/main/java/org/apache/tika/parser/recognition/tf/TensorflowRESTRecogniser.java
##########
@@ -73,19 +74,27 @@
/**
* Maximum buffer size for image
*/
- private static final String LABEL_LANG = "en";
+ protected static final String LABEL_LANG = "en";
@Field
- private URI apiUri =
URI.create("http://localhost:8764/inception/v4/classify?topk=10";);
+ protected URI apiBaseUri =
URI.create("http://localhost:8764/inception/v4";);
+
+ @Field
+ protected int topN = 2;
+
@Field
- private URI healthUri =
URI.create("http://localhost:8764/inception/v4/ping";);
+ protected double minConfidence = 0.015;
+
+ protected URI apiUri;
+
+ protected URI healthUri;
Review comment:
You can still keep a default value by extracting String constants and
deriving a default value too. No big deal though
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Standardizing current Object Recognition REST parsers
> -----------------------------------------------------
>
> Key: TIKA-2400
> URL: https://issues.apache.org/jira/browse/TIKA-2400
> Project: Tika
> Issue Type: Sub-task
> Components: parser
> Reporter: Thejan Wijesinghe
> Priority: Minor
> Fix For: 1.17
>
>
> # This involves adding apiBaseUris and refactoring current Object Recognition
> REST parsers,
> # Refactoring dockerfiles related to those parsers.
> # Moving the logic related to checking minimum confidence into servers
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
