[ https://issues.apache.org/jira/browse/TIKA-2400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16175996#comment-16175996 ]
ASF GitHub Bot commented on TIKA-2400: -------------------------------------- ThejanW commented on a change in pull request #208: Fix for TIKA-2400 Standardizing current Object Recognition REST parsers URL: https://github.com/apache/tika/pull/208#discussion_r140420704 ########## File path: tika-parsers/src/main/java/org/apache/tika/parser/recognition/ObjectRecognitionParser.java ########## @@ -83,12 +83,6 @@ public int compare(RecognisedObject o1, RecognisedObject o2) { } }; - @Field - private double minConfidence = 0.05; Review comment: sorry, I misunderstood your question, the reason why I have removed minConfidence and topN from objectRecognitionParser is, objectRecognitionParser does not need to keep such client specific parameters. Those client specific fields should be in that specific client, we are just using ObjectRecognitionParser to process objects from the respective REST client and put them in the xhtml. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Standardizing current Object Recognition REST parsers > ----------------------------------------------------- > > Key: TIKA-2400 > URL: https://issues.apache.org/jira/browse/TIKA-2400 > Project: Tika > Issue Type: Sub-task > Components: parser > Reporter: Thejan Wijesinghe > Priority: Minor > Fix For: 1.17 > > > # This involves adding apiBaseUris and refactoring current Object Recognition > REST parsers, > # Refactoring dockerfiles related to those parsers. > # Moving the logic related to checking minimum confidence into servers -- This message was sent by Atlassian JIRA (v6.4.14#64029)