[
https://issues.apache.org/jira/browse/TIKA-2400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16178403#comment-16178403
]
ASF GitHub Bot commented on TIKA-2400:
--------------------------------------
thammegowda commented on a change in pull request #208: Fix for TIKA-2400
Standardizing current Object Recognition REST parsers
URL: https://github.com/apache/tika/pull/208#discussion_r140669424
##########
File path:
tika-parsers/src/main/java/org/apache/tika/parser/captioning/tf/TensorflowRESTCaptioner.java
##########
@@ -107,7 +107,7 @@ public boolean isAvailable() {
public void initialize(Map<String, Param> params) throws
TikaConfigException {
try {
healthUri = URI.create(apiBaseUri + "/ping");
- apiUri = URI.create(apiBaseUri +
String.format(Locale.getDefault(),
"/captions?beam_size=%1$d&max_caption_length=%2$d",
+ apiUri = URI.create(apiBaseUri +
String.format(Locale.getDefault(),
"/caption/image?beam_size=%1$d&max_caption_length=%2$d",
Review comment:
Improvement: `String.format(Locale.getDefault()`, ...) and
`String.format(...)` are equivalent right (default is inferred implicitely)?
Rule of thumb - 1) When you have two options, pick the simple one! For me,
latter one looks simple
2) If you want to enforce a specific locale, then it not same as default.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Standardizing current Object Recognition REST parsers
> -----------------------------------------------------
>
> Key: TIKA-2400
> URL: https://issues.apache.org/jira/browse/TIKA-2400
> Project: Tika
> Issue Type: Sub-task
> Components: parser
> Reporter: Thejan Wijesinghe
> Priority: Minor
> Fix For: 1.17
>
>
> # This involves adding apiBaseUris and refactoring current Object Recognition
> REST parsers,
> # Refactoring dockerfiles related to those parsers.
> # Moving the logic related to checking minimum confidence into servers
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
