[
https://issues.apache.org/jira/browse/TIKA-2400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16178398#comment-16178398
]
ASF GitHub Bot commented on TIKA-2400:
--------------------------------------
thammegowda commented on a change in pull request #208: Fix for TIKA-2400
Standardizing current Object Recognition REST parsers
URL: https://github.com/apache/tika/pull/208#discussion_r140669630
##########
File path:
tika-parsers/src/main/java/org/apache/tika/parser/recognition/ObjectRecognitionParser.java
##########
@@ -83,12 +83,6 @@ public int compare(RecognisedObject o1, RecognisedObject
o2) {
}
};
- @Field
- private double minConfidence = 0.05;
Review comment:
Correct me if my understanding is wrong:
- we have removed minConfidence and topN from ObjectRecognitionParser
+ We have added them to classes that implement `ObjectRecogniser` interface
- Like TensorflowRestRecogniser, TensforflowRestImageCaptioner etc .. These
are referred as _client_ in Thejan's terminalogy
+ We also have URL accompanying each _client_, which allow tweaking of these
parameters.
Food for Design thought: We might not have URLs for every client. to be
specific - we could have a client using DL4J that doesn't use REST
communication. So these parameters are required for the client and hence they
should have it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Standardizing current Object Recognition REST parsers
> -----------------------------------------------------
>
> Key: TIKA-2400
> URL: https://issues.apache.org/jira/browse/TIKA-2400
> Project: Tika
> Issue Type: Sub-task
> Components: parser
> Reporter: Thejan Wijesinghe
> Priority: Minor
> Fix For: 1.17
>
>
> # This involves adding apiBaseUris and refactoring current Object Recognition
> REST parsers,
> # Refactoring dockerfiles related to those parsers.
> # Moving the logic related to checking minimum confidence into servers
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
