Niall Pemberton wrote:
On 2/9/07, David H. DeWolf <[EMAIL PROTECTED]> wrote:
[X] Leave at test build
[ ] Alpha
[ ] Beta
[ ] General Availability (GA)
Apologies, meant to review earlier. I have a number of comments:
Better late than never :) Sometimes it takes a vote thread to kick start
the process I guess!
- there is no source distro
- the binary distro doesn't contain the javadocs
TILES-105, TILES-106
Do these need to be in place for an alpha? IMO we're simply trying to
get binaries out. According to HTTPD docs, "Alpha indicates that the
release is not meant for mainstream usage or may have serious problems
that prohibits its use." Missing docs seem to fall in that category.
- The sources jars are a mess containing duplicate copies of the java
files as well as the "target" directory with the binary jars, classes
files and surefire reports etc
TILES-107
Hmmm. Is this a known problem with the maven-release-plugin? Anyone
know how to change this?
- the manifest files don't contain the usual entries, I'd have
expected something like:
Extension-Name: Apache Tiles Core
Specification-Title: Apache Tiles Core
Specification-Version: 2.0.0
Specification-Vendor: The Apache Software Foundation
Implementation-Title: Apache Tiles Core
Implementation-Version: 2.0.0
Implementation-Vendor: The Apache Software Foundation
Implementation-Vendor-Id: org.apache
TILES-108
- DefinitionManager in core (org.apache.tiles.impl.mgmt) is missing a
source file header
Fixed in trunk
- The notice file copyright statement is to 2006 (not 2007)
Fixed in trunk
The latter two are probably enough to -1 any release. To this end, I've
created jira issues for the above and will role 2.0.1 as soon as they
are fixed. Unless, people want to retag and try a 2.0.0 again. I'm ok
either way but would prefer the former.
Thanks for reviewing!
David
Niall
