Awesome! Thanks a ton.
David
Niall Pemberton wrote:
On 2/9/07, Niall Pemberton <[EMAIL PROTECTED]> wrote:
On 2/9/07, David H. DeWolf <[EMAIL PROTECTED]> wrote:
>
> [X] Leave at test build
> [ ] Alpha
> [ ] Beta
> [ ] General Availability (GA)
Apologies, meant to review earlier. I have a number of comments:
- there is no source distro
- the binary distro doesn't contain the javadocs
- The sources jars are a mess containing duplicate copies of the java
files as well as the "target" directory with the binary jars, classes
files and surefire reports etc
- the manifest files don't contain the usual entries, I'd have
expected something like:
Extension-Name: Apache Tiles Core
Specification-Title: Apache Tiles Core
Specification-Version: 2.0.0
Specification-Vendor: The Apache Software Foundation
Implementation-Title: Apache Tiles Core
Implementation-Version: 2.0.0
Implementation-Vendor: The Apache Software Foundation
Implementation-Vendor-Id: org.apache
- DefinitionManager in core (org.apache.tiles.impl.mgmt) is missing a
source file header
- The notice file copyright statement is to 2006 (not 2007)
I've posted a patch for all of the above (except sorting out the sources
jar)
https://issues.apache.org/struts/browse/TILES-109
Need to run mvn site assembly:assembly (site creates Javadocs first)
Not sure how to sort out the sources jars - suspect its because of one
of your resources (for NOTICE and LICENSE) has
<directory>.</directory> - maybe moving NOTICE and LICENSE to
src/main/resources would be better and avoid this. Specifying the root
directory in resource causes the plugin that creates the sources jar
all sorts of problems - think its an outstanding bug, so best avoided.
Niall
Niall
Niall
