[
https://issues.apache.org/jira/browse/TINKERPOP-1861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16321469#comment-16321469
]
ASF GitHub Bot commented on TINKERPOP-1861:
-------------------------------------------
Github user spmallette commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/772#discussion_r160839238
--- Diff:
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/computer/VertexProgram.java
---
@@ -68,7 +68,20 @@ public default void storeState(final Configuration
configuration) {
* @param graph the graph that the VertexProgram will run
against
* @param configuration the configuration to load the state of the
VertexProgram from.
*/
+ @Deprecated
--- End diff --
When we deprecate, the javadoc should also include something like:
```text
@deprecated As of release 3.2.8, replaced by {@link
#loadState(Configuration, Graph)}
```
That syntax on the link isn't quite right because Graph is varargs, but
hopefully you get the idea.
> VertexProgram create with varargs for Graphs
> --------------------------------------------
>
> Key: TINKERPOP-1861
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1861
> Project: TinkerPop
> Issue Type: Improvement
> Components: process
> Affects Versions: 3.2.7
> Reporter: Philip Graff
> Priority: Minor
>
> VertexProgram.Builder.create(Graph) can be modified to
> VertexProgram.Builder.create(Graph...) so that passing in zero or many graphs
> is naturally handled. The current state of passing in null when no graph is
> needed is bad practice.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
