[
https://issues.apache.org/jira/browse/TINKERPOP-1861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16321488#comment-16321488
]
ASF GitHub Bot commented on TINKERPOP-1861:
-------------------------------------------
Github user spmallette commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/772#discussion_r160840828
--- Diff:
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/computer/traversal/step/map/PageRankVertexProgramStep.java
---
@@ -83,17 +83,17 @@ public String toString() {
}
@Override
- public PageRankVertexProgram generateProgram(final Graph graph, final
Memory memory) {
+ public PageRankVertexProgram generateProgram(final Memory memory,
final Graph... graphs) {
final Traversal.Admin<Vertex, Edge> detachedTraversal =
this.edgeTraversal.getPure();
-
detachedTraversal.setStrategies(TraversalStrategies.GlobalCache.getStrategies(graph.getClass()));
+
detachedTraversal.setStrategies(TraversalStrategies.GlobalCache.getStrategies(graphs[0].getClass()));
--- End diff --
I've not thought this through, but I think we would only ever have one
`Graph` instance in this case - should that be validated at all?
> VertexProgram create with varargs for Graphs
> --------------------------------------------
>
> Key: TINKERPOP-1861
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1861
> Project: TinkerPop
> Issue Type: Improvement
> Components: process
> Affects Versions: 3.2.7
> Reporter: Philip Graff
> Priority: Minor
>
> VertexProgram.Builder.create(Graph) can be modified to
> VertexProgram.Builder.create(Graph...) so that passing in zero or many graphs
> is naturally handled. The current state of passing in null when no graph is
> needed is bad practice.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
