[
https://issues.apache.org/jira/browse/TINKERPOP-1861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16321477#comment-16321477
]
ASF GitHub Bot commented on TINKERPOP-1861:
-------------------------------------------
Github user spmallette commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/772#discussion_r160840279
--- Diff:
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/computer/clustering/peerpressure/PeerPressureVertexProgram.java
---
@@ -81,7 +81,11 @@ private PeerPressureVertexProgram() {
}
@Override
- public void loadState(final Graph graph, final Configuration
configuration) {
+ public void loadState(final Configuration configuration, final
Graph... graphs) {
+ if (graphs.length != 1) {
+ throw new IllegalStateException("Must provide one graph to
use, received " + graphs.length);
+ }
+ Graph graph = graphs[0];
--- End diff --
Our style is to `final` all variables that can be marked as such - it seems
like this one could be.
> VertexProgram create with varargs for Graphs
> --------------------------------------------
>
> Key: TINKERPOP-1861
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1861
> Project: TinkerPop
> Issue Type: Improvement
> Components: process
> Affects Versions: 3.2.7
> Reporter: Philip Graff
> Priority: Minor
>
> VertexProgram.Builder.create(Graph) can be modified to
> VertexProgram.Builder.create(Graph...) so that passing in zero or many graphs
> is naturally handled. The current state of passing in null when no graph is
> needed is bad practice.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
