[
https://issues.apache.org/jira/browse/TINKERPOP-1861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16321491#comment-16321491
]
ASF GitHub Bot commented on TINKERPOP-1861:
-------------------------------------------
Github user spmallette commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/772#discussion_r160841245
--- Diff:
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/computer/traversal/step/map/VertexProgramStep.java
---
@@ -64,15 +64,15 @@ public VertexProgramStep(final Traversal.Admin
traversal) {
if (this.first && this.getPreviousStep() instanceof EmptyStep)
{
this.first = false;
final Graph graph = this.getTraversal().getGraph().get();
- future =
this.getComputer().apply(graph).program(this.generateProgram(graph,
EmptyMemory.instance())).submit();
+ future =
this.getComputer().apply(graph).program(this.generateProgram(EmptyMemory.instance(),
graph)).submit();
final ComputerResult result = future.get();
this.processMemorySideEffects(result.memory());
return
this.getTraversal().getTraverserGenerator().generate(result, this, 1l);
} else {
final Traverser.Admin<ComputerResult> traverser =
this.starts.next();
final Graph graph = traverser.get().graph();
final Memory memory = traverser.get().memory();
- future =
this.generateComputer(graph).program(this.generateProgram(graph,
memory)).submit();
+ future =
this.getComputer().apply(graph).program(this.generateProgram(memory,
graph)).submit();
--- End diff --
any reason this logic is changed? it was `generateComputer()` before and
now it's `getComputer().apply()`.
> VertexProgram create with varargs for Graphs
> --------------------------------------------
>
> Key: TINKERPOP-1861
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1861
> Project: TinkerPop
> Issue Type: Improvement
> Components: process
> Affects Versions: 3.2.7
> Reporter: Philip Graff
> Priority: Minor
>
> VertexProgram.Builder.create(Graph) can be modified to
> VertexProgram.Builder.create(Graph...) so that passing in zero or many graphs
> is naturally handled. The current state of passing in null when no graph is
> needed is bad practice.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
