[
https://issues.apache.org/jira/browse/TINKERPOP-2140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16750245#comment-16750245
]
Florian Hockmann commented on TINKERPOP-2140:
---------------------------------------------
My idea here is mostly to test the {{Dockerfile}} and the Docker build scripts.
Right now, I have basically broken [~dkuppitz]'s build with my change, simply
because the Docker image couldn't be built any more on his machine, although it
worked on my machine.
In this case, I tested it manually first on my machine before I created the PR,
but I don't think that we should completely rely on all contributors to always
remember that they should do that. Testing this automatically on Travis gives
us another level of security that the Docker build still works.
But yes, in the end it's basically a smoke test.
Regarding being fast one Travis: Our slowest build job takes already up to 40
minutes on Travis. I assume that {{docker/build.sh}} without any flags will
complete faster than that, even on Travis. If it actually takes a lot longer,
then we may need to discuss whether it's worth it.
I personally would also prefer if we would execute all (or nearly all) tests
with Travis. Right now, contributors have to make sure themselves that they
test everything that could be broken by their change. Moving this to a CI
system means that we just know that everything was tested. That also makes it
easier for first time contributors as they wouldn't have to set up a full build
environment and checkout how they start the right tests. They could simply push
their code to their own fork and let Travis handle the tests. Another problem I
noticed when I worked on TinkerPop over the holidays was that the the build
with {{docker/build.sh -t -i}} took like half a day on my laptop (which is a
few years old) and the laptop was basically unusable during that time. I ended
up creating a VM with a cloud provider and executed the build there as that was
a lot faster and I could continue using my laptop in the meantime. But that is
really a different topic.
> Test build with Docker automatically
> ------------------------------------
>
> Key: TINKERPOP-2140
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2140
> Project: TinkerPop
> Issue Type: Improvement
> Components: build-release
> Affects Versions: 3.3.5
> Reporter: Florian Hockmann
> Assignee: Florian Hockmann
> Priority: Minor
>
> From time to time, we have problems with our Docker build
> ({{docker/build.sh}}). Unfortunately, these problems aren't always
> reproducible for different contributors which means that they aren't noticed
> when a PR gets tested manually, but only later after a contribution was
> already merged to a release branch.
> [Here|https://github.com/apache/tinkerpop/pull/1026#issuecomment-456816660]
> is a recent example.
> We should use Travis to also execute the Docker build automatically. That
> will hopefully at least find some problems like this before it gets merged.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
