[
https://issues.apache.org/jira/browse/TINKERPOP-2140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16750255#comment-16750255
]
stephen mallette commented on TINKERPOP-2140:
---------------------------------------------
> I assume that docker/build.sh without any flags will complete faster than
> that, even on Travis.
what does the build do without flags? same as building with {{-DskipTests}}?
> I personally would also prefer if we would execute all (or nearly all) tests
> with Travis.
We do run almost everything with Travis at this point (on {{master}} - giraph
on tp33 is just impossible and neo4j is similarly impossible). there are
different integration tests still not executed on travis. we also don't have a
test for docs which is almost like a really really long integration test, so
that's not ever executed either. i guess there's no problem in adding more
parallel jobs to travis. would be nice if we could consolidate better somehow
though while gaining better coverage. would be nice if we just had regular
{{mvn clean install}} and then {{docker/build.sh -t -i -n}} but i think the
latter is just not going to run in a time that travis will be happy with.
anyway, if you can propose some good changes in this area, i'd be open to them.
> docker/build.sh -t -i took like half a day on my laptop
that's pretty slow if you're talking about the master branch. tp33 will take
that long because of giraph though. i have a second laptop near by that i
usually do builds on. that helps keep my primary system free.
> Test build with Docker automatically
> ------------------------------------
>
> Key: TINKERPOP-2140
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2140
> Project: TinkerPop
> Issue Type: Improvement
> Components: build-release
> Affects Versions: 3.3.5
> Reporter: Florian Hockmann
> Assignee: Florian Hockmann
> Priority: Minor
>
> From time to time, we have problems with our Docker build
> ({{docker/build.sh}}). Unfortunately, these problems aren't always
> reproducible for different contributors which means that they aren't noticed
> when a PR gets tested manually, but only later after a contribution was
> already merged to a release branch.
> [Here|https://github.com/apache/tinkerpop/pull/1026#issuecomment-456816660]
> is a recent example.
> We should use Travis to also execute the Docker build automatically. That
> will hopefully at least find some problems like this before it gets merged.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
