[
https://issues.apache.org/jira/browse/TINKERPOP-2140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16752491#comment-16752491
]
Florian Hockmann commented on TINKERPOP-2140:
---------------------------------------------
{quote}what does the build do without flags? same as building with
{{-DskipTests}}?
{quote}
If my understand of [this bash
code|https://github.com/apache/tinkerpop/blob/70f72e3642cbc4b31c63bdff5378a652256de56b/docker/scripts/build.sh#L42]
is right, then yes :D (my bash skills are really bad):
{code}
case "$1" in
-t | --tests ) RUN_TESTS=tue; shift ;;
# [...]
[ -z "${RUN_TESTS}" ] && TINKERPOP_BUILD_OPTIONS="${TINKERPOP_BUILD_OPTIONS}
-DskipTests"{code}
{{tue}} should probably also be {{true}}. I'll fix that with a CTR commit.
{quote}would be nice if we just had regular {{mvn clean install}} and then
{{docker/build.sh -t -i -n}} but i think the latter is just not going to run in
a time that travis will be happy with.
{quote}
Yes, I think it won't work with the Docker build script like that as Travis
build jobs have to complete [in under 50
minutes|https://docs.travis-ci.com/user/customizing-the-build/#build-timeouts].
That is also why [JanusGraph uses so many parallel build
jobs|https://travis-ci.org/JanusGraph/janusgraph].
We could however use a similar approach and create a separate build job for
each project, at least for projects that aren't already fully tested by the
existing jobs.
> Test build with Docker automatically
> ------------------------------------
>
> Key: TINKERPOP-2140
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2140
> Project: TinkerPop
> Issue Type: Improvement
> Components: build-release
> Affects Versions: 3.3.5
> Reporter: Florian Hockmann
> Assignee: Florian Hockmann
> Priority: Minor
>
> From time to time, we have problems with our Docker build
> ({{docker/build.sh}}). Unfortunately, these problems aren't always
> reproducible for different contributors which means that they aren't noticed
> when a PR gets tested manually, but only later after a contribution was
> already merged to a release branch.
> [Here|https://github.com/apache/tinkerpop/pull/1026#issuecomment-456816660]
> is a recent example.
> We should use Travis to also execute the Docker build automatically. That
> will hopefully at least find some problems like this before it gets merged.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
