[
https://issues.apache.org/jira/browse/TINKERPOP-2140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16752492#comment-16752492
]
ASF GitHub Bot commented on TINKERPOP-2140:
-------------------------------------------
FlorianHockmann commented on pull request #1048: TINKERPOP-2140 Add CI smoke
test for Docker build on Travis
URL: https://github.com/apache/tinkerpop/pull/1048
https://issues.apache.org/jira/browse/TINKERPOP-2140
This additional Travis build job checks whether the Docker build still works.
The job took 21 minutes [on
Travis](https://travis-ci.org/apache/tinkerpop/builds/484445855) which is still
faster than the Spark job which took 26 minutes. So, this doesn't negatively
impact our build times on Travis.
This could also have been a CTR commit, but maybe someone wants to review.
Otherwise I'll merge it with lazy consensus.
VOTE +1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Test build with Docker automatically
> ------------------------------------
>
> Key: TINKERPOP-2140
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2140
> Project: TinkerPop
> Issue Type: Improvement
> Components: build-release
> Affects Versions: 3.3.5
> Reporter: Florian Hockmann
> Assignee: Florian Hockmann
> Priority: Minor
>
> From time to time, we have problems with our Docker build
> ({{docker/build.sh}}). Unfortunately, these problems aren't always
> reproducible for different contributors which means that they aren't noticed
> when a PR gets tested manually, but only later after a contribution was
> already merged to a release branch.
> [Here|https://github.com/apache/tinkerpop/pull/1026#issuecomment-456816660]
> is a recent example.
> We should use Travis to also execute the Docker build automatically. That
> will hopefully at least find some problems like this before it gets merged.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
