[
https://issues.apache.org/jira/browse/TINKERPOP-3186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18030459#comment-18030459
]
ASF GitHub Bot commented on TINKERPOP-3186:
-------------------------------------------
kenhuuu commented on code in PR #3242:
URL: https://github.com/apache/tinkerpop/pull/3242#discussion_r2437372007
##########
gremlin-javascript/src/main/javascript/gremlin-javascript/lib/structure/graph.js:
##########
@@ -46,9 +46,10 @@ class Graph {
}
class Element {
- constructor(id, label) {
+ constructor(id, label, properties = undefined) {
Review Comment:
This breaks a bit with what `gremlin-python` does, but wouldn't it be better
for this to just do `properties = []` here? Since undefined isn't the same as
null it makes the assignment to `this.properties` below a little cleaner.
> Inconsistency of properties data type on Element
> ------------------------------------------------
>
> Key: TINKERPOP-3186
> URL: https://issues.apache.org/jira/browse/TINKERPOP-3186
> Project: TinkerPop
> Issue Type: Improvement
> Components: javascript
> Affects Versions: 3.7.4
> Reporter: Stephen Mallette
> Assignee: Stephen Mallette
> Priority: Blocker
> Labels: breaking
>
> The {{properties}} property on {{Element}} in javascript has datatypes
> inconsistent with Java and other GLVs where it can be a {{Map}}, {{List}} or
> {{undefined}} depending on serializer or other factors (and we go through
> great lengths to assert all of this in tests for some reason). The type
> should be {{List}}. Use an empty list if {{null}} or {{undefined}}.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
