[
https://issues.apache.org/jira/browse/TINKERPOP-3186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18031167#comment-18031167
]
ASF GitHub Bot commented on TINKERPOP-3186:
-------------------------------------------
spmallette commented on code in PR #3242:
URL: https://github.com/apache/tinkerpop/pull/3242#discussion_r2445222447
##########
docs/src/upgrade/release-3.8.x.asciidoc:
##########
@@ -301,10 +301,27 @@ g.inject("Hello").split("")
See: link:https://issues.apache.org/jira/browse/TINKERPOP-3083[TINKERPOP-3083]
==== asString() No Longer Allow Nulls
-The `asString()` step will no longer allow `null` input. An
`IllegalArgumentException` will be thrown for consistency with all other
parsing steps (i.e. `asDate()`, `asBool()`, `asNumber()`).
+
+The `asString()` step will no longer allow `null` input. An
`IllegalArgumentException` will be thrown for consistency
+with all other parsing steps (i.e. `asDate()`, `asBool()`, `asNumber()`).
See:
link:https://lists.apache.org/thread/q76pgrvhprosb4lty63bnsnbw2ljyl7m[DISCUSS]
thread
+==== Properties on Element Serialization in Python & Javascript
+
+Element properties handling has been inconsistent across GLVs. Previously,
`gremlin-python` deserialized empty properties as `None`, while
Review Comment:
i think you should clarify that this is talking about situations where
properties on elements are enabled. rather than just referencing
"Elements.properties` please share an example. also rather than just declaring
it a "breaking change" with an explanation of what to do, work that into the
example.
the "Note:" at the end, i don't think formats as a "NOTE:" but i'm not sure
if you were meaning it that way or not. we usually don't use "NOTE:" in Upgrade
Docs as best i can recall. That aside, I think this is a good thought but i
don't think it will be clear to most users what that means. I think it would be
good to expand this part into a paragraph to better explain.
> Inconsistency of properties data type on Element
> ------------------------------------------------
>
> Key: TINKERPOP-3186
> URL: https://issues.apache.org/jira/browse/TINKERPOP-3186
> Project: TinkerPop
> Issue Type: Improvement
> Components: javascript
> Affects Versions: 3.7.4
> Reporter: Stephen Mallette
> Assignee: Stephen Mallette
> Priority: Blocker
> Labels: breaking
>
> The {{properties}} property on {{Element}} in javascript has datatypes
> inconsistent with Java and other GLVs where it can be a {{Map}}, {{List}} or
> {{undefined}} depending on serializer or other factors (and we go through
> great lengths to assert all of this in tests for some reason). The type
> should be {{List}}. Use an empty list if {{null}} or {{undefined}}.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
