[
https://issues.apache.org/jira/browse/TINKERPOP-3186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18030879#comment-18030879
]
ASF GitHub Bot commented on TINKERPOP-3186:
-------------------------------------------
vkagamlyk commented on code in PR #3242:
URL: https://github.com/apache/tinkerpop/pull/3242#discussion_r2442554346
##########
gremlin-javascript/src/main/javascript/gremlin-javascript/test/integration/client-tests.js:
##########
@@ -119,17 +119,11 @@ describe('Client', function () {
assert.strictEqual(result.length, 1);
const vertex = result.first();
assert.ok(vertex instanceof graphModule.Vertex);
- // if/then until TINKERPOP-3186
let age, name
- if (vertex.properties instanceof Array) {
- const ageProps = vertex.properties.filter(p => p.key === 'age');
- const nameProps = vertex.properties.filter(p => p.key === 'name');
- age = ageProps[0];
- name = nameProps[0];
- } else {
- age = vertex.properties.age[0]
- name = vertex.properties.name[0]
- }
+ const ageProps = vertex.properties.filter(p => p.key === 'age');
Review Comment:
nit: can be simplified to something like
`const age = vertex.properties.find(p => p.key === 'age');`
> Inconsistency of properties data type on Element
> ------------------------------------------------
>
> Key: TINKERPOP-3186
> URL: https://issues.apache.org/jira/browse/TINKERPOP-3186
> Project: TinkerPop
> Issue Type: Improvement
> Components: javascript
> Affects Versions: 3.7.4
> Reporter: Stephen Mallette
> Assignee: Stephen Mallette
> Priority: Blocker
> Labels: breaking
>
> The {{properties}} property on {{Element}} in javascript has datatypes
> inconsistent with Java and other GLVs where it can be a {{Map}}, {{List}} or
> {{undefined}} depending on serializer or other factors (and we go through
> great lengths to assert all of this in tests for some reason). The type
> should be {{List}}. Use an empty list if {{null}} or {{undefined}}.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
