[ 
https://issues.apache.org/jira/browse/TINKERPOP3-886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14996414#comment-14996414
 ] 

ASF GitHub Bot commented on TINKERPOP3-886:
-------------------------------------------

Github user dkuppitz commented on a diff in the pull request:

    https://github.com/apache/incubator-tinkerpop/pull/141#discussion_r44267313
  
    --- Diff: docs/src/implementations.asciidoc ---
    @@ -630,7 +630,8 @@ TinkerGraph has several settings that can be provided 
on creation via `Configura
     value is specified here, the the `gremlin.tinkergraph.graphFormat` should 
also be specified.  If this value is not
     included (default), then the graph will stay in-memory and not be 
loaded/persisted to disk.
     |gremlin.tinkergraph.graphFormat |The format to use to serialize the graph 
which may be one of the following:
    -`graphml`, `graphson`, or `gryo`. If a value is specified here, the the 
`gremlin.tinkergraph.graphLocation` should
    +`graphml`, `graphson`, gryo`, or a fully qualified class name that 
implements Io.Builder interface.
    +If a value is specified here, the the `gremlin.tinkergraph.graphLocation` 
should
    --- End diff --
    
    Typo."the the" => "then the"


> Allow any GraphReader/Writer to be persistence engine for TinkerGraph 
> ----------------------------------------------------------------------
>
>                 Key: TINKERPOP3-886
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP3-886
>             Project: TinkerPop 3
>          Issue Type: Improvement
>          Components: tinkergraph
>    Affects Versions: 3.0.2-incubating
>            Reporter: stephen mallette
>            Assignee: stephen mallette
>            Priority: Trivial
>
> TinkerGraph currently works with gryo, graphml and graphson - all internal 
> formats to TinkerPop.  This could easily be extended to work with any format 
> implementing the appropriate interfaces (i.e. also external third-party 
> formats) by allowing for the `gremlin.tinkergraph.graphFormat` setting for 
> TinkerGraph to be set to the existing three settings, but also allow for it 
> to be the fully qualified class name for a {{Io.Builder<I extends Io>}} 
> interface.  TinkerGraph could then dynamically instantiate this class (which 
> we can expect to have a zero-arg constructor) and use it to load/save data.  
> This might actually also clean up some of the existing code around load/save.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to