[
https://issues.apache.org/jira/browse/TINKERPOP3-886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14999421#comment-14999421
]
ASF GitHub Bot commented on TINKERPOP3-886:
-------------------------------------------
Github user kushal256 commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/141#issuecomment-155581913
Thanks for your comments. Yes, there should be similar logic for writing
graph.
Also, I agree, there should be tests, but I'm not sure how to do so when
using reflection (Class.forName() and newInstance() for creating new
Io.Builder), with mockito's stubs. Any recommendations for how to do this?
On Nov 9, 2015 4:13 AM, "Daniel Kuppitz" <[email protected]> wrote:
> I agree, I'd also like to see that covered by one or two tests.
>
> —
> Reply to this email directly or view it on GitHub
>
<https://github.com/apache/incubator-tinkerpop/pull/141#issuecomment-155047954>
> .
>
> Allow any GraphReader/Writer to be persistence engine for TinkerGraph
> ----------------------------------------------------------------------
>
> Key: TINKERPOP3-886
> URL: https://issues.apache.org/jira/browse/TINKERPOP3-886
> Project: TinkerPop 3
> Issue Type: Improvement
> Components: tinkergraph
> Affects Versions: 3.0.2-incubating
> Reporter: stephen mallette
> Assignee: stephen mallette
> Priority: Trivial
>
> TinkerGraph currently works with gryo, graphml and graphson - all internal
> formats to TinkerPop. This could easily be extended to work with any format
> implementing the appropriate interfaces (i.e. also external third-party
> formats) by allowing for the `gremlin.tinkergraph.graphFormat` setting for
> TinkerGraph to be set to the existing three settings, but also allow for it
> to be the fully qualified class name for a {{Io.Builder<I extends Io>}}
> interface. TinkerGraph could then dynamically instantiate this class (which
> we can expect to have a zero-arg constructor) and use it to load/save data.
> This might actually also clean up some of the existing code around load/save.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
