[
https://issues.apache.org/jira/browse/TINKERPOP3-886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14996421#comment-14996421
]
ASF GitHub Bot commented on TINKERPOP3-886:
-------------------------------------------
Github user spmallette commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/141#issuecomment-155047685
Thanks for working on this. I see you did something for reading a graph,
but what about writing?
https://github.com/kushal256/incubator-tinkerpop/blob/master/tinkergraph-gremlin/src/main/java/org/apache/tinkerpop/gremlin/tinkergraph/structure/TinkerGraph.java#L296
Note that the docs needed to be updated:
https://github.com/apache/incubator-tinkerpop/blob/master/docs/src/implementations.asciidoc#configuration
Specifically, the configuration description for
`gremlin.tinkergraph.graphFormat` needs something to denote this new feature.
Would be nice to see a test case as well. Perhaps you could stub a
reader/writer and assert that the class gets created and the appropriate
methods are called. wdyt?
I'm not sure how others feel, but I think we will wait to merge this until
after release of 3.1.0-incubating (in code freeze for that now).
> Allow any GraphReader/Writer to be persistence engine for TinkerGraph
> ----------------------------------------------------------------------
>
> Key: TINKERPOP3-886
> URL: https://issues.apache.org/jira/browse/TINKERPOP3-886
> Project: TinkerPop 3
> Issue Type: Improvement
> Components: tinkergraph
> Affects Versions: 3.0.2-incubating
> Reporter: stephen mallette
> Assignee: stephen mallette
> Priority: Trivial
>
> TinkerGraph currently works with gryo, graphml and graphson - all internal
> formats to TinkerPop. This could easily be extended to work with any format
> implementing the appropriate interfaces (i.e. also external third-party
> formats) by allowing for the `gremlin.tinkergraph.graphFormat` setting for
> TinkerGraph to be set to the existing three settings, but also allow for it
> to be the fully qualified class name for a {{Io.Builder<I extends Io>}}
> interface. TinkerGraph could then dynamically instantiate this class (which
> we can expect to have a zero-arg constructor) and use it to load/save data.
> This might actually also clean up some of the existing code around load/save.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
