On Thu, May 9, 2019 at 4:47 PM Mark Thomas <ma...@apache.org> wrote: > On 09/05/2019 14:38, Rémy Maucherat wrote: > > <snip/> > > >> +1 to hard-coding to a single acceptor thread and removing the plumbing > >> that supports more than that. > > > > Ok, done. > > Great. > > > So I suppose you prefer keeping the ability to have multiple poller > threads > > for NIO ? > > NIO defaults to 1 anyway. > > I agree with that multiple Poller threads is unlikely to offer a > performance benefit in any realistic scenario. > > APR only supported multiple Poller threads because of a Windows XP / > Server 2003 issue that limited poller size to 1024. Other than that, > comments in the APR code indicate a preference for a single Poller. >
Yes, I ran into that then ... > > I've no objection to making a similar change to the pollerThreadCount. > Ok, so this is turning into a large refactoring. I'll put it up for review first, even though the testsuite looks ok (locally, so it means nothing I guess, haha). Rémy
